Skip fetching event payloads when streaming events #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerbertJordan
requested review from
jmpike,
thaarok and
jenikd
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the requesting of event payload data when streaming events from other nodes.
Receiving messaged from a stream of events with payload currently leads to a message parsing error, causing the peer connection used for streaming those events to be disconnected. After a time-out of a few seconds, another attempt for streaming events is started -- however in the second attempt only event IDs are fetched, which then succeeds.
During syncing, this effect can be observed by the process seemingly freezing between epochs for a few seconds. With this fix, this effect disappears.
Besides disabling requests of event streams with payload, this PR also upgrades the reporting of communication issues to the log-level of a warning to allow issues like this to be detected more easily in the future.