Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip fetching event payloads when streaming events #372

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

HerbertJordan
Copy link
Collaborator

This PR disables the requesting of event payload data when streaming events from other nodes.

Receiving messaged from a stream of events with payload currently leads to a message parsing error, causing the peer connection used for streaming those events to be disconnected. After a time-out of a few seconds, another attempt for streaming events is started -- however in the second attempt only event IDs are fetched, which then succeeds.

During syncing, this effect can be observed by the process seemingly freezing between epochs for a few seconds. With this fix, this effect disappears.

Besides disabling requests of event streams with payload, this PR also upgrades the reporting of communication issues to the log-level of a warning to allow issues like this to be detected more easily in the future.

Copy link
Collaborator

@jmpike jmpike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks.

@HerbertJordan HerbertJordan merged commit 2494188 into develop Dec 4, 2024
2 checks passed
@HerbertJordan HerbertJordan deleted the herbert/skip_fetching_of_events_in_stream branch December 4, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants